Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Snackbar): fix rtl view #8109

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Conversation

EldarMuhamethanov
Copy link
Contributor

  • Unit-тесты
  • e2e-тесты
  • Release notes

Описание

Сейчас в компоненте Snackbar анимации появления и скрытия компонента происходят инвертированно в rtl

Изменения

Доработал логику и стили компонента Snackbar , так чтобы анимации появления/скрытия компонента работала правильно в режиме rtl

Release notes

Улучшения

  • Snackbar: Добавлена поддержка rtl

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

size-limit report 📦

Path Size
JS 389.17 KB (+0.05% 🔺)
JS (gzip) 118.14 KB (+0.09% 🔺)
JS (brotli) 97.27 KB (+0.1% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 341.88 KB (+0.11% 🔺)
CSS (gzip) 42.32 KB (+0.09% 🔺)
CSS (brotli) 33.7 KB (-0.06% 🔽)

Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 21fcca6

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.51%. Comparing base (b5f950e) to head (21fcca6).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
packages/vkui/src/components/Snackbar/utils.ts 75.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8109      +/-   ##
==========================================
- Coverage   95.55%   95.51%   -0.04%     
==========================================
  Files         398      398              
  Lines       11326    11338      +12     
  Branches     3731     3742      +11     
==========================================
+ Hits        10822    10830       +8     
- Misses        504      508       +4     
Flag Coverage Δ
unittests 95.51% <80.95%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@EldarMuhamethanov EldarMuhamethanov merged commit e31540f into master Dec 28, 2024
27 of 29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/rtl/Snackbar branch December 28, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants