-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(HorizontalScroll, CardScroll): Add testid props for arrows #8032
feat(HorizontalScroll, CardScroll): Add testid props for arrows #8032
Conversation
Remove test specific test ids to prefer props
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests
|
👀 Docs deployed
Commit 6ab0a1b |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8032 +/- ##
=======================================
Coverage 95.47% 95.48%
=======================================
Files 393 392 -1
Lines 11188 11153 -35
Branches 3708 3677 -31
=======================================
- Hits 10682 10649 -33
+ Misses 506 504 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Обновил JSDoc в соответствии с новым правилом для пропов |
сорри, немного запоздал с ревью в случае UPD |
@inomdzhon ты чертовски прав, я как-то не заметил и больше думал про имена из логических свойств. |
✅ v7.1.0 🎉 |
Описание
Добавляем свойства для прокидывания data-testid на стрелки.
Убираем старые, зашитые в код testId.
Release notes
Улучшения
data-testid
в стрелки навигации с помощью новых свойствstartArrowTestId
иendArrowTestId
.data-testid
в стрелки навигации с помощью новых свойствstartArrowTestId
иendArrowTestId
.