feat(Gallery): add testid's to elements and refactor #8015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8015 +/- ##
=======================================
Coverage 95.51% 95.51%
=======================================
Files 394 396 +2
Lines 11228 11235 +7
Branches 3720 3720
=======================================
+ Hits 10724 10731 +7
Misses 504 504
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
👀 Docs deployed
Commit ce1060c |
# Conflicts: # packages/vkui/src/components/BaseGallery/BaseGallery.tsx # packages/vkui/src/components/BaseGallery/CarouselBase/CarouselBase.tsx
andrey-medvedev-vk
previously approved these changes
Dec 4, 2024
BlackySoul
reviewed
Dec 5, 2024
BlackySoul
approved these changes
Dec 5, 2024
andrey-medvedev-vk
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Нужно добавить возможность прокидывать test-id для необходимых интерактивных элементов
Изменения
Bullets, который ренедерит bullet'ыGalleryViewPort, который ренедерит слайдыnextArrowTestId,prevArrowTestIdbulletTestIdslideTestIdRelease notes
Улучшения
data-testidдля стрелок переключения слайдов:nextArrowTestId,prevArrowTestId;data-testidдля bullet'ов –bulletTestId;data-testidдля слайдов –slideTestId.