Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CustomScrollView): add prop scrollBehavior #7976

Merged

Conversation

EldarMuhamethanov
Copy link
Contributor


  • Unit-тесты
  • Документация фичи
  • Release notes

Описание

Нужно добавить свойство scrollBehavior, которое отвечает за стиль scroll-behavior в компонента CustomScrollView

Release notes

Улучшения

  • CustomScrollView: добавлено свойство scrollBehavior, которое отвечает за настройку стиля scroll-behavior

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner November 22, 2024 10:04
Copy link
Contributor

size-limit report 📦

Path Size
JS 385.73 KB (+0.03% 🔺)
JS (gzip) 116.98 KB (+0.03% 🔺)
JS (brotli) 96.23 KB (+0.05% 🔺)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 334.86 KB (+0.02% 🔺)
CSS (gzip) 42.36 KB (+0.02% 🔺)
CSS (brotli) 33.38 KB (-0.14% 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 39333be

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.35%. Comparing base (77fe44d) to head (39333be).
Report is 59 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7976      +/-   ##
==========================================
+ Coverage   95.32%   95.35%   +0.02%     
==========================================
  Files         379      379              
  Lines       11302    11316      +14     
  Branches     3764     3774      +10     
==========================================
+ Hits        10774    10790      +16     
+ Misses        528      526       -2     
Flag Coverage Δ
unittests 95.35% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Dec 2, 2024
@EldarMuhamethanov EldarMuhamethanov removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Dec 2, 2024
@EldarMuhamethanov EldarMuhamethanov merged commit 48aabcc into master Dec 3, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/7932/add-scroll-behavior-prop branch December 3, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][CustomScrollView]: Добавить scrollBehavior проп
4 participants