Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ContentCard): fix height of ContentCard content #7945

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Nov 15, 2024


  • Release notes

Описание

Сейчас контент карточки не всегда растягивается на всю высоту самой карточки, поэтому ховер на карточку выглядит некорректно

Изменения

Добавил растягивание на 100% контента карточки

Release notes

Исправления

  • ContentCard: поправлен баг с растягиванием контента карточки на всю высоту карточки

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner November 15, 2024 11:47
Copy link
Contributor

size-limit report 📦

Path Size
JS 381.64 KB (0%)
JS (gzip) 115.73 KB (0%)
JS (brotli) 95.23 KB (0%)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 332.72 KB (+0.01% 🔺)
CSS (gzip) 42.16 KB (+0.01% 🔺)
CSS (brotli) 33.26 KB (+0.07% 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 68d811a

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.30%. Comparing base (933f11e) to head (68d811a).
Report is 100 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7945   +/-   ##
=======================================
  Coverage   95.30%   95.30%           
=======================================
  Files         378      378           
  Lines       11195    11195           
  Branches     3735     3735           
=======================================
  Hits        10669    10669           
  Misses        526      526           
Flag Coverage Δ
unittests 95.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Nov 27, 2024
@EldarMuhamethanov EldarMuhamethanov removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Nov 27, 2024
@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Dec 5, 2024
@EldarMuhamethanov EldarMuhamethanov merged commit 09a9c40 into master Dec 10, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/7900/fix-card-hover branch December 10, 2024 13:27
@inomdzhon
Copy link
Contributor

мб патч в v7.0.1?

@EldarMuhamethanov EldarMuhamethanov added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Dec 11, 2024
EldarMuhamethanov added a commit that referenced this pull request Dec 16, 2024
EldarMuhamethanov added a commit that referenced this pull request Dec 16, 2024
EldarMuhamethanov added a commit that referenced this pull request Dec 16, 2024
* fix(ContentCard): fix height of ContentCard content (#7945)

(cherry picked from commit 09a9c40)

* fix(PanelHeader): hide separator with transparent PanelHeader (#8006)

* fix(PanelHeader): hide separator with transparent PanelHeader

* fix(PanelHeader): run prettier

(cherry picked from commit c22b02b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Card hover неправильно отрабатывает
5 participants