Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1119 filter metadata from api #1642

Merged
merged 5 commits into from
Apr 3, 2023
Merged

1119 filter metadata from api #1642

merged 5 commits into from
Apr 3, 2023

Conversation

RyanRConaway
Copy link
Contributor

Ticket Link #111

Description

  • High level overview of changes
  • ...

Reminders:

  • Be mindful of impacts of changing Major/Minor/Patch versions of each elixir app:
    • If updating patch version, are you sure there are no chart changes required to maintain functionality? If so, you should bump minor version instead.
    • If updating Major or Minor versions , did you update the sauron chart configuration?
  • If changing elixir code in an "app", did you update the relevant version
    in mix.exs?
  • If altering an API endpoint, was the relevant postman collection updated?
    • If a new version of smart_city is being used (new fields on a struct), were the relevant postman collections updated?

nicholas-goodwin
nicholas-goodwin reviewed Apr 3, 2023
View reviewed changes
apps/raptor_service/lib/raptor_service.ex
@@ -102,7 +102,7 @@ defmodule RaptorService do
end

def check_auth0_role(raptor_url, api_key, role) do
case HTTPoison.get(url_for_checking_role(raptor_url, api_key, role) |> IO.inspect(label: "RYAN - URL")) do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

real quick IO inspect

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhhh, that's not mine? I've never seen that IO inspect in my life!

@RyanRConaway RyanRConaway merged commit f0b2500 into master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholas-goodwin nicholas-goodwin nicholas-goodwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanRConaway @nicholas-goodwin