Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download button #1634

Merged
merged 3 commits into from
Mar 23, 2023
Merged

Conversation

jfolk2015
Copy link
Contributor

@jfolk2015 jfolk2015 commented Mar 22, 2023

Ticket Link #1050

Description

  • When api keys are requried, always validate hmac tokens on download requests
  • Preserve existing functionality when api keys are not required (no token needed if public, needed if private)
  • Removed add user details plugs from download pipeline because it wasn't used but will cause errors when api keys are required

Reminders:

  • Be mindful of impacts of changing Major/Minor/Patch versions of each elixir app:
    • If updating patch version, are you sure there are no chart changes required to maintain functionality? If so, you should bump minor version instead.
  • If changing elixir code in an "app", did you update the relevant version
    in mix.exs?

@jfolk2015 jfolk2015 merged commit 3557c93 into master Mar 23, 2023
@jfolk2015 jfolk2015 deleted the 1050-fix-downloads-when-api-keys-required branch March 23, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants