Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added XML check to HTTP and Auth Step #1629

Merged
merged 4 commits into from
Mar 17, 2023
Merged

added XML check to HTTP and Auth Step #1629

merged 4 commits into from
Mar 17, 2023

Conversation

nicholas-goodwin
Copy link
Contributor

Ticket Link #1082

Description

  • Added XML check to HTTP and Auth steps so that the body can be XML without failing

Reminders:

  • Be mindful of impacts of changing Major/Minor/Patch versions of each elixir app:
    • If updating patch version, are you sure there are no chart changes required to maintain functionality? If so, you should bump minor version instead.
    • If updating Major or Minor versions , did you update the sauron chart configuration?
  • If changing elixir code in an "app", did you update the relevant version
    in mix.exs?
  • If altering an API endpoint, was the relevant postman collection updated?
    • If a new version of smart_city is being used (new fields on a struct), were the relevant postman collections updated?

ian-j-abbott-accenture
ian-j-abbott-accenture approved these changes Mar 17, 2023
View reviewed changes
apps/andi/lib/andi/input_schemas/ingestions/extract_steps/extract_auth_step.ex Outdated
changeset
catch
:exit, _ ->
Changeset.add_error(changeset, :body, "could not parse json", validation: :format)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a blurb about not being able to parse xml as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't what the UI shows, due to the error_tag function, but still good catch

apps/andi/lib/andi/input_schemas/ingestions/extract_steps/extract_http_step.ex Outdated
changeset
catch
:exit, _ ->
Changeset.add_error(changeset, :body, "could not parse json", validation: :format)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as other comment

@nicholas-goodwin nicholas-goodwin merged commit fa2fe39 into master Mar 17, 2023
@nicholas-goodwin nicholas-goodwin deleted the 1082-XML-HTTP-Step branch March 17, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian-j-abbott-accenture ian-j-abbott-accenture ian-j-abbott-accenture approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholas-goodwin @ian-j-abbott-accenture