Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1084 ftp #1626

Merged
merged 6 commits into from
Mar 15, 2023
Merged

1084 ftp #1626

merged 6 commits into from
Mar 15, 2023

Conversation

ian-j-abbott-accenture
Copy link
Contributor

@ian-j-abbott-accenture ian-j-abbott-accenture commented Mar 14, 2023

Ticket Link #1084

Description

Fix credential issue where secrets were not being properly applied to the request

Reminders:

  • Be mindful of impacts of changing Major/Minor/Patch versions of each elixir app:
    • If updating patch version, are you sure there are no chart changes required to maintain functionality? If so, you should bump minor version instead.
    • If updating Major or Minor versions , did you update the sauron chart configuration?
  • If changing elixir code in an "app", did you update the relevant version
    in mix.exs?
  • If altering an API endpoint, was the relevant postman collection updated?
    • If a new version of smart_city is being used (new fields on a struct), were the relevant postman collections updated?

@ian-j-abbott-accenture ian-j-abbott-accenture merged commit 26ae026 into master Mar 15, 2023
@ian-j-abbott-accenture ian-j-abbott-accenture deleted the 1084-ftp branch March 15, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants