Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust css so accordion mouse-over area is consistent #1603

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

ian-j-abbott-accenture
Copy link
Contributor

@ian-j-abbott-accenture ian-j-abbott-accenture commented Feb 8, 2023

Ticket Link #1003

Description

Adjust css so accordion mouse over behavior is consistent

Reminders:

  • Be mindful of impacts of changing Major/Minor/Patch versions of each elixir app:
    • If updating patch version, are you sure there are no chart changes required to maintain functionality? If so, you should bump minor version instead.
    • If updating Major or Minor versions , did you update the sauron chart configuration?
  • If changing elixir code in an "app", did you update the relevant version
    in mix.exs?
  • [ ] If altering an API endpoint, was the relevant postman collection updated?
    • [ ] If a new version of smart_city is being used (new fields on a struct), were the relevant postman collections updated?

@@ -60,7 +60,7 @@ defmodule AndiWeb.IngestionLiveView.FinalizeForm do
end

~L"""
<div id="finalize_form" class="finalize-form finalize-form--<%= @visibility %>">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the other steps in ingestion need the same touch or do they work the same?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need it for the first and last steps. This is so the line that extends between the step numbers doesn't overflow

@ian-j-abbott-accenture ian-j-abbott-accenture merged commit 512d2af into master Feb 9, 2023
@ian-j-abbott-accenture ian-j-abbott-accenture deleted the 1003-accordion-mouse-over-accuracy branch February 9, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants