Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the main/header html positions for screen readers #1574

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Conversation

c-m-duncan
Copy link
Contributor

@c-m-duncan c-m-duncan commented Jan 6, 2023

Ticket Link #981

Description

No visual changes happened, just switched around the elements and added aria-labels. Was careful to make sure that the footer popping-up didn't return

image

Reminders:

  • Be mindful of impacts of changing Major/Minor/Patch versions of each elixir app
    • If updating patch version, are you sure there are no chart changes required to maintain functionality? If so, you should bump minor version instead.
    • If updating Major or Minor versions , did you update the sauron chart configuration?
  • If changing elixir code in an "app", did you update the relevant version
    in mix.exs?
  • If altering an API endpoint, was the relevant postman collection updated?
    • If a new version of smart_city is being used (new fields on a struct), were the relevant postman collections updated?

@c-m-duncan c-m-duncan merged commit 2c17374 into master Jan 6, 2023
@c-m-duncan c-m-duncan deleted the 981 branch January 25, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants