936 require api key #1560
Merged
936 require api key #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijabbott
commented
Dec 16, 2022
|
|
||
| defp assign_current_user(conn, current_user, api_key) when is_nil(current_user) and is_nil(api_key) do | ||
| render_401_missing_api_key(conn) | ||
| # assign(conn, :current_user, current_user) |
There was a problem hiding this comment.
testing a few things around this 401 missing case, will remove comment after that's done
bmitchinson
reviewed
Dec 16, 2022
bmitchinson
reviewed
Dec 16, 2022
bmitchinson
reviewed
Dec 16, 2022
apps/discovery_api/lib/discovery_api_web/plugs/set_current_user.ex
Outdated
Show resolved
Hide resolved
bmitchinson
approved these changes
Dec 16, 2022
| end | ||
|
|
||
| defp assign_current_user(conn, current_user, api_key) when is_nil(current_user) and not is_nil(api_key) do | ||
| case RaptorService.get_user_id_from_api_key(raptor_url(), api_key) do |
There was a problem hiding this comment.
@nicholas-goodwin This line here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link #936
Description
When REQUIRE_API_KEY is true, require api_key to be passed in as a header for discovery-api requests if the request does not already contain valid user login information. This should result in api_key being required on requests not coming from discovery-ui.
Reminders:
in
mix.exs?smart_cityis being used (new fields on a struct), were the relevant postman collections updated?