Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scheme validation to extract url #1559

Merged
merged 7 commits into from
Dec 17, 2022
Merged

Add scheme validation to extract url #1559

merged 7 commits into from
Dec 17, 2022

Conversation

c-m-duncan
Copy link
Contributor

Ticket Link #967

Description

Adds uri validation to the ingestion form - specifically around the scheme (http/https)

image

Reminders:

  • Be mindful of impacts of changing Major/Minor/Patch versions of each elixir app
    • If updating patch version, are you sure there are no chart changes required to maintain functionality? If so, you should bump minor version instead.
    • If updating Major or Minor versions , did you update the sauron chart configuration?
  • If changing elixir code in an "app", did you update the relevant version
    in mix.exs?
  • If altering an API endpoint, was the relevant postman collection updated?
    • If a new version of smart_city is being used (new fields on a struct), were the relevant postman collections updated?

RyanRConaway
RyanRConaway reviewed Dec 15, 2022
View reviewed changes
apps/andi/lib/andi_web/live/ingestion_live_view/extract_steps/extract_http_step_form.ex
@@ -52,7 +52,7 @@ defmodule AndiWeb.ExtractSteps.ExtractHttpStepForm do

<div class="extract-http-step-form__url">
<%= label(f, :url, DisplayNames.get(:url), class: "label label--required") %>
<%= text_input(f, :url, [id: "step_#{@id}__url", class: "input full-width", disabled: @testing, required: true]) %>
<%= url_input(f, :url, [id: "step_#{@id}__url", class: "input full-width", disabled: @testing, required: true]) %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. What does this do? The docs are very descriptive and say "Generates an url input."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing, it's just an alias for text_input. I liked that it was a little more descriptive.

@c-m-duncan c-m-duncan merged commit 2ebe3ed into master Dec 17, 2022
@c-m-duncan c-m-duncan deleted the 967 branch January 25, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanRConaway RyanRConaway RyanRConaway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-m-duncan @RyanRConaway