Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed test coding surrouding publish #1551

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

nicholas-goodwin
Copy link
Contributor

Description

  • Cleaning up code to not have unneeded IO.inspects in it

Reminders:

  • Be mindful of impacts of changing Major/Minor/Patch versions of each elixir app
    • If updating patch version, are you sure there are no chart changes required to maintain functionality? If so, you should bump minor version instead.
      - [ ] If updating Major or Minor versions , did you update the sauron chart configuration?
      - [ ] If changing elixir code in an "app", did you update the relevant version
      in mix.exs?
      - [ ] If altering an API endpoint, was the relevant postman collection updated?
      - [ ] If a new version of smart_city is being used (new fields on a struct), were the relevant postman collections updated?

Copy link
Contributor

@c-m-duncan c-m-duncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@nicholas-goodwin nicholas-goodwin merged commit a26d23f into master Dec 2, 2022
@nicholas-goodwin nicholas-goodwin deleted the remove-IO.inspects-from-codebase branch December 9, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants