added error result to http responses #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholas-goodwin
commented
Nov 2, 2022
| @@ -31,7 +31,7 @@ defmodule Reaper.DataSlurper.Http do | |||
| "Unable to retrieve data for #{ingestion_id}: #{Exception.message(error)}" | |||
| end) | |||
|
|
|||
| reraise error, __STACKTRACE__ | |||
| reraise inspect(error), __STACKTRACE__ | |||
There was a problem hiding this comment.
this came about because the HTTPError that was boiling up from the Task.Await on line 39 ended up like {{%HTTPError}} for some reason with no real way of removing it without erroring out further when another exception came through. Would gladly change this if solution could be found.
bmitchinson
approved these changes
Nov 2, 2022
nicholas-goodwin
deleted the
885-Reaper-not-ingesting-data-after-failing-ingestion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link #885
Description
Reminders:
- [ ] If updating Major or Minor versions , did you update the sauron chart configuration?in
mix.exs?- [ ] If altering an API endpoint, was the relevant postman collection updated?- [ ] If a new version ofsmart_cityis being used (new fields on a struct), were the relevant postman collections updated?