879 missing icons #1500
Merged
879 missing icons #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ving unnecessary webpack values
…tiesdata into 879-missing-icons
nicholas-goodwin
approved these changes
Oct 17, 2022
c-m-duncan
reviewed
Oct 17, 2022
| from: :andi, | ||
| gzip: false, | ||
| only: ~w(css fonts images js favicon.ico) | ||
| end |
There was a problem hiding this comment.
Oh so do we not need this since we're now hosting the font / icons ourselves?
There was a problem hiding this comment.
No, we do need it. But it already exists under apps/andi/lib/andi_web/endpoint.ex.
c-m-duncan
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link #879
Description
Restoring icons which aren't material icons throughout Andi. Cleaning up some changes from self-hosting.
Reminders:
- [] If updating Major or Minor versions , did you update the sauron chart configuration?in
mix.exs?- [] If altering an API endpoint, was the relevant postman collection updated?- [] If a new version ofsmart_cityis being used (new fields on a struct), were the relevant postman collections updated?