Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add button type to buttons #1492

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Conversation

ijabbott
Copy link
Contributor

@ijabbott ijabbott commented Sep 29, 2022

Ticket Link #864

Description

  • Add type="button" to transformation icons

Reminders:

  • [ ] Be mindful of impacts of changing Major/Minor/Patch versions of each elixir app
    • [ ] If updating patch version, are you sure there are no chart changes required to maintain functionality? If so, you should bump minor version instead.
    • [ ] If updating Major or Minor versions , did you update the sauron chart configuration?
  • If changing elixir code in an "app", did you update the relevant version
    in mix.exs?
  • [ ] If altering an API endpoint, was the relevant postman collection updated?
    • [ ] If a new version of smart_city is being used (new fields on a struct), were the relevant postman collections updated?

@ijabbott ijabbott merged commit 82acbba into master Sep 29, 2022
@ijabbott ijabbott deleted the 864-andi-transformation-delete-move-bug branch September 29, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants