subtract transformation #1464
Merged
subtract transformation #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ defmodule Transformers.MixProject do | |||
| def project do | |||
| [ | |||
| app: :transformers, | |||
| version: "1.0.2", | |||
| version: "1.0.4", | |||
There was a problem hiding this comment.
Jumping straight to 4 assuming the multiplication PR will go out before ours
| defp subtractValues(minuend, subtrahends, payload) do | ||
| minuendValue = Map.get(payload, minuend, minuend) | ||
|
|
||
| if is_number(minuendValue) do |
There was a problem hiding this comment.
This can likely be cleaned up if we have a validate_parameters and validate_payload in the future.
jfolk2015
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link #554
Description
Reminders:
in
mix.exs?