Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trino upgrade #1432

Merged
merged 11 commits into from
Jul 27, 2022
Merged

Trino upgrade #1432

merged 11 commits into from
Jul 27, 2022

Conversation

LtChae
Copy link
Contributor

@LtChae LtChae commented Jul 25, 2022

Ticket Link #712

Description

  • Updated all apps that use prestige to use the new version that handles Trino
  • Updated pipeline to use the new version of prestige
  • Updated docker-compose files with the latest postgres, metastore, minio, and trino

Reminders:

  • If changing elixir code in an "app", did you update the relevant version
    in mix.exs?
  • If altering an API endpoint, was the relevant postman collection updated?
    • If a new version of smart_city is being used (new fields on a struct), were the relevant postman collections updated?

Comment on lines +94 to +98
redis:
image: redis:latest
ports:
- "6379:6379"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to using these new images, maybe test startup time will be a bit faster.

Why was the redis healthcheck removed? As well as metastore's. Can the new images for those have healthchecks? I believe divo uses them to surface if there was issues starting them up, which has been helpful in the past.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, a valid question. I haven't noticed issues with startup so far. Maybe as part of a followup card assuming the builds go well?

@bmitchinson
Copy link
Member

@LtChae you'll need to update the forklift mix.exs

@LtChae LtChae merged commit d9cf29c into master Jul 27, 2022
@LtChae LtChae deleted the trino-upgrade branch July 27, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants