-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trino upgrade #1432
Trino upgrade #1432
Conversation
redis: | ||
image: redis:latest | ||
ports: | ||
- "6379:6379" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to using these new images, maybe test startup time will be a bit faster.
Why was the redis healthcheck removed? As well as metastore's. Can the new images for those have healthchecks? I believe divo uses them to surface if there was issues starting them up, which has been helpful in the past.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, a valid question. I haven't noticed issues with startup so far. Maybe as part of a followup card assuming the builds go well?
@LtChae you'll need to update the forklift mix.exs |
Ticket Link #712
Description
Reminders:
in
mix.exs
?smart_city
is being used (new fields on a struct), were the relevant postman collections updated?