Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overwrite_mode to forklift config map #1427

Merged
merged 6 commits into from
Jul 26, 2022

Conversation

bmitchinson
Copy link
Member

@bmitchinson bmitchinson commented Jul 21, 2022

Ticket Link #760

Description

Leaving as a draft until base image issues are resolved.

Reminders:

  • If changing elixir code in an "app", did you update the relevant version
    in mix.exs?
  • NA If altering an API endpoint, was the relevant postman collection updated?
    • NA If a new version of smart_city is being used (new fields on a struct), were the relevant postman collections updated?

@bmitchinson bmitchinson marked this pull request as ready for review July 22, 2022 20:40
@@ -147,6 +147,9 @@ if System.get_env("COMPACTION_SCHEDULE") do
]
end

config :forklift,
overwrite_mode: !!System.get_env("OVERWRITE_MODE")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have concerns about the readability of this. Notnot in front of a direct environment variable call is a bit opaque. Consider a case block that clearly lays out the possible values of the variable and assigns a boolean value based on it

Copy link
Member Author

@bmitchinson bmitchinson Jul 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

204b775

Corrected this in the above commit, good advice. Requesting reapproval.

@bmitchinson bmitchinson merged commit 5bb31e7 into master Jul 26, 2022
@bmitchinson bmitchinson deleted the 760-forklift-overwrite-config branch July 26, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants