Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

753 ignore events which reference non-existent dataset models #1413

Merged
merged 8 commits into from
Jul 12, 2022
Merged

753 ignore events which reference non-existent dataset models #1413

merged 8 commits into from
Jul 12, 2022

Conversation

jfolk2015
Copy link
Contributor

Ticket Link #759

Description

Fixing an issue where discovery api would fail to process an associate or disassociate event if the dataset model was missing, and then would not process further events.

Reminders:

  • If changing elixir code in an "app", did you update the relevant version
    in mix.exs?

@jfolk2015 jfolk2015 changed the title 753 ignore nil datasets 753 ignore events which reference non-existent dataset models Jul 11, 2022
bmitchinson
bmitchinson approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@bmitchinson bmitchinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, one comment but non blocking.

@jfolk2015 jfolk2015 merged commit 1223189 into master Jul 12, 2022
@jfolk2015 jfolk2015 deleted the 753-ignore-nil-datasets branch July 12, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmitchinson bmitchinson bmitchinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfolk2015 @bmitchinson