add an option for disable shift + clear #368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yaya-Cout
requested changes
Jun 17, 2024
apps/settings/base.en.i18n
Outdated
| @@ -81,3 +81,4 @@ ExtAppWriteExplanation1 = "By default, external applications" | |||
| ExtAppWriteExplanation2 = "cannot write to memory" | |||
| ExtAppWriteExplanation3 = "flash (persistent) of your calculator." | |||
| ExtAppEnabled = "Pin up" | |||
| Clearshiftlock = "shortcut shift + clear" | |||
There was a problem hiding this comment.
Would it be possible to capitalize first letter ? (in others languages too)
apps/global_preferences.h
Outdated
| @@ -36,6 +36,8 @@ class GlobalPreferences { | |||
| void setAutocomplete(bool autocomple) { m_autoComplete = autocomple; } | |||
| bool syntaxhighlighting() const { return m_syntaxhighlighting; } | |||
| void setSyntaxhighlighting(bool syntaxhighlight) { m_syntaxhighlighting = syntaxhighlight; } | |||
| bool clearalphalockshift() const { return m_clearalphalockshift; } | |||
| void setclearalphalockshift(bool clearalphalockshift) { m_clearalphalockshift = clearalphalockshift; } | |||
There was a problem hiding this comment.
Why alphalock ? Isn't this about Shift + Clear ?
Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>
|
|
|
i hope i havent break all |
|
cool is ok |
|
|
Yaya-Cout
reviewed
Jun 18, 2024
Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>
Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>
|
ok is beacaus i have change function name and e not variable name |
|
1 similar comment
|
|
|
thank you for your patience I think everything is ok now |
|
|
why the test dosent complet ? |
quentinguidee
suggested changes
Sep 23, 2024
Comment on lines
+39
to
+40
| bool clearshift() const { return m_clearkshift; } | ||
| void setclearshift(bool clearalphashift) { m_clearkshift = clearalphashift; } |
There was a problem hiding this comment.
Better to use camelCase here for consistency
There was a problem hiding this comment.
Still not fixed (should be setClearShift and clearShift)
| @@ -81,3 +81,4 @@ ExtAppWriteExplanation1 = "Standardmäßig externe Anwendungen" | |||
| ExtAppWriteExplanation2 = "kann nicht in den Speicher schreiben" | |||
| ExtAppWriteExplanation3 = "Flash (dauerhaft) Ihres Rechners." | |||
| ExtAppEnabled = "Aufstecken" | |||
| Clearshift = "Tastenkombination Umschalt + Löschen" | |||
There was a problem hiding this comment.
Same (PascalCase for all i18n files)
There was a problem hiding this comment.
Still not fixed (should be ClearShift instead of Clearshift)
| @@ -48,8 +53,10 @@ HighlightCell * CodeOptionsController::reusableCell(int index, int type) { | |||
| } | |||
| else if (index == 1) { | |||
| return &m_switchCellAutoCompletion; | |||
| }else if (index == 2) { | |||
There was a problem hiding this comment.
Suggested change
| }else if (index == 2) { | |
| } else if (index == 2) { |
Co-authored-by: Quentin <github@arra.red>
|
thx |
Yaya-Cout
requested changes
Mar 8, 2025
Comment on lines
+39
to
+40
| bool clearshift() const { return m_clearkshift; } | ||
| void setclearshift(bool clearalphashift) { m_clearkshift = clearalphashift; } |
There was a problem hiding this comment.
Can you explain what the k in m_clearkshift means? Also, avoid doubles spaces
Suggested change
| bool clearshift() const { return m_clearkshift; } | |
| void setclearshift(bool clearalphashift) { m_clearkshift = clearalphashift; } | |
| bool clearshift() const { return m_clearkshift; } | |
| void setclearshift(bool clearalphashift) { m_clearkshift = clearalphashift; } |
| @@ -80,6 +83,7 @@ class GlobalPreferences { | |||
| bool m_dfuUnlocked; | |||
| bool m_autoComplete; | |||
| bool m_syntaxhighlighting; | |||
| bool m_clearkshift; | |||
There was a problem hiding this comment.
Suggested change
| bool m_clearkshift; | |
| bool m_clearkshift; |
| @@ -81,3 +81,4 @@ ExtAppWriteExplanation1 = "Standardmäßig externe Anwendungen" | |||
| ExtAppWriteExplanation2 = "kann nicht in den Speicher schreiben" | |||
| ExtAppWriteExplanation3 = "Flash (dauerhaft) Ihres Rechners." | |||
| ExtAppEnabled = "Aufstecken" | |||
| Clearshift = "Tastenkombination Umschalt + Löschen" | |||
There was a problem hiding this comment.
Still not fixed (should be ClearShift instead of Clearshift)
| @@ -48,8 +53,10 @@ HighlightCell * CodeOptionsController::reusableCell(int index, int type) { | |||
| } | |||
| else if (index == 1) { | |||
| return &m_switchCellAutoCompletion; | |||
| }else if (index == 2) { | |||
Comment on lines
+39
to
+40
| bool clearshift() const { return m_clearkshift; } | ||
| void setclearshift(bool clearalphashift) { m_clearkshift = clearalphashift; } |
There was a problem hiding this comment.
Still not fixed (should be setClearShift and clearShift)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i have code this issue #285