[bootloader/storage] new bootloader and fix python issue #205

devdl11 · 2022-04-07T18:00:45Z

An amazing Upsilon Bootloader !
Thanks @Yaya-Cout for helping me bring this beauty to life ;-)
I also fix by the way the python issue

github-actions · 2022-04-07T18:06:32Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

github-actions · 2022-04-07T18:12:40Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

github-actions · 2022-04-07T20:23:44Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

bootloader/itoa.cpp

bootloader/itoa.h

Lauryy06 · 2022-04-08T07:52:03Z

ion/src/device/shared/drivers/display.cpp

@@ -51,7 +51,7 @@ bool waitForVBlank() {
  uint64_t startTime = Timing::millis();
  uint64_t timeout = startTime + timeoutDelta;

-  /* If current time is big enough, currentTime + timeout wraps around the
+  /* If current time is big enough, currentTime + timeout wraps aroud the


Lauryy06 · 2022-04-08T07:52:52Z

ion/src/device/shared/drivers/reset.cpp

@@ -49,7 +49,7 @@ void jump(uint32_t jumpIsrVectorAddress) {
  // Disable cache before reset
  Ion::Device::Cache::disable();

-  /* Shutdown all clocks and peripherals to mimic a hardware reset. */
+  /* Shutdown all clocks and periherals to mimic a hardware reset. */


? Changed correct spelling to wrong spelling

Lauryy06 · 2022-04-08T07:52:59Z

ion/src/device/shared/drivers/wakeup.h

@@ -8,7 +8,7 @@ namespace Device {
 namespace WakeUp {

 /* All wakeup functions can be called together without overwriting the same
- * register. All together, they will set SYSCFG and EXTi registers as follow:
+ * register. All togethed, they will set SYSCFG and EXTi registers as follow:


Lauryy06 · 2022-04-08T07:53:24Z

ion/src/device/shared/regs/tim.h

@@ -17,7 +17,7 @@ class TIM {
  };

  class CCMR : Register64 {
-    /* We're declaring CCMR as a 64 bits register. CCMR doesn't exist per se,
+    /* We're declaring CCMR as a 64 bits register. CCMR doesn't exsist per se,


Lauryy06 · 2022-04-08T07:53:43Z

ion/src/device/shared/usb/calculator.h

@@ -155,7 +155,7 @@ class Calculator : public Device {
  ExtendedCompatIDDescriptor m_extendedCompatIdDescriptor;

  Descriptor * m_descriptors[8];
-  /* m_descriptors contains only descriptors that should be returned via the
+  /* m_descriptors contains only descriptors that sould be returned via the


Co-authored-by: Lauryy06 <80424145+Lauryy06@users.noreply.github.com>

github-actions · 2022-04-08T11:22:03Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

github-actions · 2022-04-08T11:22:16Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

github-actions · 2022-04-08T11:22:34Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

github-actions · 2022-04-08T11:27:47Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

github-actions · 2022-04-08T11:31:49Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

github-actions · 2022-04-08T11:34:21Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

…psilon into upsilon-new-bootloader

github-actions · 2022-04-08T11:57:43Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

github-actions · 2022-04-08T12:07:14Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

bootloader/messages.h

bootloader/usb_data.h

Yaya-Cout · 2022-04-08T15:45:09Z

build/device/secure_ext.py

+# Disable Script
+sys.exit(0)


Yes, but why are you not removing it from the Makefile ?

ion/src/device/bootloader/usb/Makefile

Yaya-Cout · 2022-04-08T15:54:22Z

ion/src/device/shared/drivers/exam_mode.cpp

-  uint32_t * persistence_end_32 = (uint32_t *)&_exam_mode_buffer_end;
-  assert((persistence_end_32 - persistence_start_32) % 4 == 0);
-  while (persistence_start_32 < persistence_end_32 && *persistence_start_32 == 0x0) {
+  uint32_t * persitence_start_32 = (uint32_t *)&_exam_mode_buffer_start;


Why do you edit it ?

ion/src/device/shared/usb/dfu.ld

ion/src/device/shared/usb/dfu_interface.h

ion/src/device/shared/usb/dfu_relocated.cpp

ion/src/device/shared/usb/stack/device.cpp

Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>

github-actions · 2022-04-25T16:29:01Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

github-actions · 2022-04-25T16:46:44Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

github-actions · 2022-04-25T17:58:09Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

Yaya-Cout

Please remove themes/themes/local/upsilon_light/bootloader/computer.xcf

bootloader/boot.h

bootloader/drivers/stm32_drivers.h

bootloader/interface/menus/about.cpp

bootloader/interface/menus/about.h

bootloader/interface/menus/crash.cpp

bootloader/interface/menus/installer.h

bootloader/interface/menus/slot_recovery.cpp

bootloader/interface/menus/slot_recovery.h

bootloader/interface/menus/warning.cpp

bootloader/interface/menus/warning.h

Co-authored-by: Yaya-Cout <yaya.cout@free.fr>

github-actions · 2022-04-26T13:31:57Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

github-actions · 2022-04-26T16:16:07Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

bootloader/interface/static/messages.h

Yaya-Cout · 2022-04-27T11:04:36Z

bootloader/interface/static/messages.h

+
+  constexpr static const char * bootloaderVersion = "Version 1.0.0 - FREED0M";
+
+  //USB NAMES


Why do you use capitals letters ?

Because it's more stylish😎😎

Co-authored-by: Yaya-Cout <yaya.cout@free.fr>

github-actions · 2022-04-27T13:51:10Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

github-actions · 2022-04-27T13:53:29Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

bootloader/interface/menus/dfu.h

Co-authored-by: Yaya-Cout <yaya.cout@free.fr>

github-actions · 2022-04-27T17:03:07Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

…psilon into upsilon-new-bootloader

github-actions · 2022-04-27T17:31:24Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

github-actions · 2022-04-27T18:03:32Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

Yaya-Cout · 2022-04-27T18:08:49Z

bootloader/boot.cpp

+  // Ion::Device::Flash::DisableInternalProtection();
+  // Ion::Device::Flash::EraseSector(0);


Remove comments if unused (below too)

Suggested change

// Ion::Device::Flash::DisableInternalProtection();

// Ion::Device::Flash::EraseSector(0);

it's for the next update x)

But I think i found something out

github-actions · 2022-04-27T18:43:12Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	814864 bytes	439766 bytes	225896 bytes	1776 bytes	227672 bytes	1256406 bytes
Head	813476 bytes	438837 bytes	225896 bytes	1776 bytes	227672 bytes	1254089 bytes
	-1388 bytes	-929 bytes	+0 bytes	+0 bytes	+0 bytes	-2317 bytes
	-0.2 %	-0.2 %	+0.0 %	+0.0 %	+0.0 %	-0.2 %

[bootloader/storage] new bootloader and fix python issue

3dfc8d7

[DFU] Fix simulators

15801ae

[Review] Review Update

c65b1c6

Lauryy06 reviewed Apr 8, 2022

View reviewed changes

devdl11 and others added 6 commits April 8, 2022 13:16

Update bootloader/itoa.cpp

3328bc2

Co-authored-by: Lauryy06 <80424145+Lauryy06@users.noreply.github.com>

Update bootloader/itoa.cpp

8db0514

Co-authored-by: Lauryy06 <80424145+Lauryy06@users.noreply.github.com>

Update bootloader/itoa.cpp

3af3d70

Co-authored-by: Lauryy06 <80424145+Lauryy06@users.noreply.github.com>

Update bootloader/itoa.h

d3754a9

Co-authored-by: Lauryy06 <80424145+Lauryy06@users.noreply.github.com>

Update bootloader/usb_data.cpp

80f099c

Co-authored-by: Lauryy06 <80424145+Lauryy06@users.noreply.github.com>

Update bootloader/itoa.cpp

7a6c211

Co-authored-by: Lauryy06 <80424145+Lauryy06@users.noreply.github.com>

devdl11 added 2 commits April 8, 2022 13:49

[Reviews] Code correction and improvement

62e9810

Merge branch 'upsilon-new-bootloader' of https://github.com/devdl11/U…

ff40b8b

…psilon into upsilon-new-bootloader

[Review] Class to namespace

3c26035

Yaya-Cout reviewed Apr 8, 2022

View reviewed changes

devdl11 and others added 5 commits April 8, 2022 18:02

Update bootloader/messages.h

7ce3aac

Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>

Update bootloader/messages.h

e886863

Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>

Update bootloader/usb_data.h

3c098b6

Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>

Update ion/src/device/bootloader/usb/Makefile

01c3f76

Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>

Update ion/src/device/n0100/flash.ld

4a830a0

Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>

devdl11 added 2 commits April 25, 2022 18:35

Fix CLI bootloader

27cf6a0

second patch

42368ec

Boot fix

18ff283

devdl11 marked this pull request as ready for review April 26, 2022 10:46

Yaya-Cout requested changes Apr 26, 2022

View reviewed changes

Apply suggestions from code review

0e49d23

Co-authored-by: Yaya-Cout <yaya.cout@free.fr>

Removing useless file

04ae526

Yaya-Cout reviewed Apr 27, 2022

View reviewed changes

devdl11 and others added 2 commits April 27, 2022 15:44

Reviews

0332f43

Update bootloader/interface/static/messages.h

45b4dd3

Co-authored-by: Yaya-Cout <yaya.cout@free.fr>

Yaya-Cout reviewed Apr 27, 2022

View reviewed changes

bootloader/interface/menus/dfu.h Outdated Show resolved Hide resolved

Update bootloader/interface/menus/dfu.h

4755844

Co-authored-by: Yaya-Cout <yaya.cout@free.fr>

devdl11 added 2 commits April 27, 2022 19:24

Some code

c73b13b

Merge branch 'upsilon-new-bootloader' of https://github.com/devdl11/U…

35f09ed

…psilon into upsilon-new-bootloader

Dumb error fix

fd7bdc7

Yaya-Cout reviewed Apr 27, 2022

View reviewed changes

Yaya-Cout mentioned this pull request Apr 27, 2022

[CI] Fix N0110 and Bootloader #215

Merged

fix

9c69379

Yaya-Cout merged commit 7f8e6a6 into UpsilonNumworks:upsilon-dev May 7, 2022


		constexpr static const char * bootloaderVersion = "Version 1.0.0 - FREED0M";

		//USB NAMES

		// Ion::Device::Flash::DisableInternalProtection();
		// Ion::Device::Flash::EraseSector(0);

[bootloader/storage] new bootloader and fix python issue #205

[bootloader/storage] new bootloader and fix python issue #205

Conversation

devdl11 commented Apr 7, 2022 • edited Loading

github-actions bot commented Apr 7, 2022

github-actions bot commented Apr 7, 2022

github-actions bot commented Apr 7, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Apr 8, 2022

github-actions bot commented Apr 8, 2022

github-actions bot commented Apr 8, 2022

github-actions bot commented Apr 8, 2022

github-actions bot commented Apr 8, 2022

github-actions bot commented Apr 8, 2022

github-actions bot commented Apr 8, 2022

github-actions bot commented Apr 8, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Apr 25, 2022

github-actions bot commented Apr 25, 2022

github-actions bot commented Apr 25, 2022

Yaya-Cout left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Apr 26, 2022

github-actions bot commented Apr 26, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Apr 27, 2022

github-actions bot commented Apr 27, 2022

github-actions bot commented Apr 27, 2022

github-actions bot commented Apr 27, 2022

github-actions bot commented Apr 27, 2022

Choose a reason for hiding this comment

devdl11 Apr 27, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Apr 27, 2022

devdl11 commented Apr 7, 2022 •

edited

Loading

Yaya-Cout left a comment •

edited

Loading

devdl11 Apr 27, 2022 •

edited

Loading