Fix context value reference changing across rendering #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tymek
approved these changes
Mar 21, 2025
Comment on lines
+109
to
+113
| const on = useCallback( | ||
| (event: string, callback: Function, ctx?: any) => | ||
| client.current.on(event, callback, ctx), | ||
| [] | ||
| ) as IFlagContextValue['on']; |
There was a problem hiding this comment.
Maybe just wrapping a function works here?
Suggested change
| const on = useCallback( | |
| (event: string, callback: Function, ctx?: any) => | |
| client.current.on(event, callback, ctx), | |
| [] | |
| ) as IFlagContextValue['on']; | |
| const on = useCallback<IFlagContextValue['on']>(client.current.on, []); |
Comment on lines
+125
to
+129
| const updateContext = useCallback( | ||
| async (context: IMutableContext) => | ||
| await client.current.updateContext(context), | ||
| [] | ||
| ) as IFlagContextValue['updateContext']; |
There was a problem hiding this comment.
Even if this cannot be bound directly, useCallback is a generic:
const updateContext = useCallback<IFlagContextValue['updateContext']>(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
About the changes
Implemented useCallback to maintain stable function references across render cycles. This prevents performance issues caused when unmemoized functions create new instances on each render.
Important files
FlagProvider.tsx:109-150