Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2021.3] Patch recent mono_ppdb_lookup_location_internal change #1954

Closed
wants to merge 1 commit into from

Conversation

jhcdunity3d
Copy link
Collaborator

Need to ensure that the ptr is advanced with mono_metadata_decode_value and the continue statement still happens.

This is a fix PR to an issue that was discovered upstream. Here is the upstream patch ihttps://github.com/dotnet/runtime#97392

Backport of #1941

  • Should this pull request have release notes?
    • Yes
    • No
  • Do these changes need to be back ported?
    • Yes
    • No
  • Do these changes need to be upstreamed to mono/mono or dotnet/runtime repositories?
    • Yes
    • No

Reviewers: please consider these questions as well! ❤️

Release notes

Internal @bholmes :
Mono: Patch recent mono_ppdb_lookup_location_internal change

Need to ensure that the ptr is advanced with mono_metadata_decode_value and the continue statement still happens.
@jhcdunity3d jhcdunity3d requested review from bholmes and removed request for bholmes January 25, 2024 18:28
@jhcdunity3d
Copy link
Collaborator Author

Oh whoops didn't need to go back to 2021.3 - closing

@jhcdunity3d jhcdunity3d deleted the 2021.3-bugfix/uum-4341-2 branch January 25, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants