This repository was archived by the owner on Sep 1, 2022. It is now read-only.
AzimuthalEquidistant did not handle spherical Earth #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creation of spherical Earth object did not check whether an Earth radius had been found in attributes, so object would be created with hard-coded default.
The call to readStandardParams would create a null Earth object if the attributes specified a spherical Earth. This would lead to subsequent NPE when creating a EquidistantAzimuthalProjection here.
|
Thank you @msdsoftware! We plan to get a 4.6.11 release the week after Thanksgiving, and this fix will be in there. |
|
@lesserwhirls, Good to know. I'm planning a Panoply +0.0.1 release before the end of the month and will try to wait for 4.6.11. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost identical to the previous problem with handling the cylindrical equal area (#614), the azimuthal equidistant was experiencing an NPE if the grid mapping variable attributes described a spherical Earth. Solution, create a spherical Earth object if the call to makeCoordinateTransform did not construct an object.
Also set handling the spherical case of both these projections to watch for a specified Earth radius, and to pass that along when creating the Earth object. The previous update to handling the CEA did not do so.