This repository was archived by the owner on Sep 1, 2022. It is now read-only.
Refactor NEXRAD level2 format checking #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't try to enumerate all the possible values. Instead, just look for AR2V and a number--and log a warning is this number is bigger than the most recent we are aware of. Also refactor to eliminate duplicated code. Backport of Unidata/netcdf-java#153, Unidata/netcdf-java#154, and Unidata/netcdf-java#189
|
Passing on travis: https://travis-ci.org/github/Unidata/thredds/builds/734276877 |
dopplershift
approved these changes
Oct 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @dopplershift's original commit message:
Backport of Unidata/netcdf-java#153, Unidata/netcdf-java#154, and Unidata/netcdf-java#189