GRIB table updates

[lesserwhirls]

Updated the following GRIB tables:

• MRMS GRIB2 Tables to v12.0.
• NCEP GRIB 1 Tables.
• experimental HRRR GRIB2 tables to v4.
• NDFD GRIB2 tables to reflect degrib v2.25.

Fixed the following new test failures:

• Two new failing tests due to GRIB name changes due to the GRIB table updates.
• Unrelated test failure to due an updated last modified time for OSDC object store test.

Finally, bumped the version of the apache xmlbeans dependency.

The full test run against this PR is passing on Jenkins.

---

This change is 

[haileyajohnson]

wow, @lesserwhirls this seems like it was really tedious 😬
Looks good to me, as long as the Python checks out with @dopplershift !

Reviewed 32 of 32 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dopplershift)

[lesserwhirls]

Yeah, the python is a bit of a hot mess, but not too terribly so. @dopplershift - I modified what you had before to work with python 3, and to provide the option to interactively look at the differences between MRMS tables when there are differences between tables for a given discipline-category-number combination.

[dopplershift]

The Python is complicated, but it's by no means an abomination.

I've made some comments to varying degrees from nitpicky to some good improvements. Feel free to disregard anything you don't feel like dealing with--the important thing is that it produces the file you want.

[dopplershift]

This could just be the else clause to the if block right above, since the only way valid_selection is set to True is if you get in one of those. You could also make the whole while block a while True: and use break to leave it and completely eliminate valid_selection.

[lesserwhirls]

Thanks for the feedback @dopplershift! Should have those taken care of in the latest changes.

[lesserwhirls]

Reviewable status: 28 of 32 files reviewed, 11 unresolved discussions (waiting on @dopplershift, @haileyajohnson, and @lesserwhirls)

---

grib/src/main/resources/resources/grib2/mrms/convert_mrms_table.py, line 142 at r1 (raw file):

Previously, dopplershift (Ryan May) wrote…

I think this should do the same:

for version in range(1, len(param_versions)):
    if not parameter_comparison(first, param_versions[version]):
        break
else: # Didn't break
    unique_params.append(param_versions[-1])
    continue

dupes += 1
...

I'm not sure if that's actually clearer, but it eliminates the has_diffs flag.

Done.

---

grib/src/main/resources/resources/grib2/mrms/convert_mrms_table.py, line 164 at r1 (raw file):

Previously, lesserwhirls (Sean Arms) wrote…

sigh got it now, missed it before. Thanks for the catch!

Done.

---

grib/src/main/resources/resources/grib2/mrms/convert_mrms_table.py, line 179 at r1 (raw file):

Previously, dopplershift (Ryan May) wrote…

This could just be the else clause to the if block right above, since the only way valid_selection is set to True is if you get in one of those. You could also make the whole while block a while True: and use break to leave it and completely eliminate valid_selection.

Done.

---

grib/src/main/resources/resources/grib2/mrms/convert_mrms_table.py, line 206 at r1 (raw file):

Previously, dopplershift (Ryan May) wrote…

pathlib may make things easier here:

from pathlib import Path
tables = Path('tables/').iterdir()

Done.

---

grib/src/main/resources/resources/grib2/mrms/convert_mrms_table.py, line 211 at r1 (raw file):

Previously, lesserwhirls (Sean Arms) wrote…

I was trying to support these three cases:

convert_mrms_table.py --tables path/to/table1

convert_mrms_table.py --tables path/to/table1 --tables path/to/table2

convert_mrms_table.py --tables path/to/table1 path/to/table2

which required that .add_argument use action='append', nargs='+'. That resulted in argparse creating a list of lists. However, that's just overcomplicating things really, so I've simplified it by only supporting the case of multiple --table flags (see update).

Done.

---

grib/src/main/resources/resources/grib2/mrms/convert_mrms_table.py, line 213 at r1 (raw file):

Previously, dopplershift (Ryan May) wrote…

Usually no spaces around = here.

Done.

[lesserwhirls]

Reviewable status: 28 of 32 files reviewed, 11 unresolved discussions (waiting on @dopplershift and @haileyajohnson)

---

grib/src/main/resources/resources/grib2/mrms/convert_mrms_table.py, line 3 at r1 (raw file):

Previously, dopplershift (Ryan May) wrote…

Usually from datetime import datetime, but not a huge deal either.

Done.

---

grib/src/main/resources/resources/grib2/mrms/convert_mrms_table.py, line 7 at r1 (raw file):

Previously, dopplershift (Ryan May) wrote…

exists isn't being used

Done.

---

grib/src/main/resources/resources/grib2/mrms/convert_mrms_table.py, line 61 at r1 (raw file):

Previously, dopplershift (Ryan May) wrote…

Could use f-strings and parentheses to replace with:

return (f'{param.Discipline}, {param.Category}, {param.Parameter}, "{param.Name}", '
        f'"{param.Description}", "{param.Unit}", {param.No_Coverage}, '
        f'{param.Missing}')

That's purely stylistic though.

Done.

---

grib/src/main/resources/resources/grib2/mrms/convert_mrms_table.py, line 69 at r1 (raw file):

Previously, dopplershift (Ryan May) wrote…

Same thing here.

Done.