Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the data_word_size from the level 2 message #514

Merged
merged 2 commits into from
Oct 9, 2020

Conversation

lesserwhirls
Copy link
Collaborator

@lesserwhirls lesserwhirls commented Oct 7, 2020

Previously, the level 2 code used a fixed word size of 8 bits for the
data blocks, with a special exception for the differential phase
product, which was hardcoded to use 16 bits. This PR enables the IOSP
and Level2 Record parser to use the actual word size as encoded in the
message.


This change is Reviewable

@lesserwhirls lesserwhirls marked this pull request as draft October 7, 2020 23:07
lesserwhirls added a commit to lesserwhirls/thredds that referenced this pull request Oct 8, 2020
Backport of Unidata/netcdf-java#514

Previously, the level 2 code used a fixed word size of 8 bits for the
data blocks, with a special exception for the differential phase
product, which was hardcoded to use 16 bits. This PR enables the IOSP
and Level2 Record parser to use the actual word size as encoded in the
message.
@lesserwhirls lesserwhirls marked this pull request as ready for review October 8, 2020 14:27
Previously, the level 2 code used a fixed word size of 8 bits for the
data blocks, with a special exception for the differential phase
product, which was hardcoded to use 16 bits. This PR enables the IOSP
and Level2 Record parser to use the actual word size as encoded in the
message.
Limit log messages for missing types to one message per type per pointer
location.
lesserwhirls added a commit to lesserwhirls/thredds that referenced this pull request Oct 8, 2020
Backport of Unidata/netcdf-java#514

Previously, the level 2 code used a fixed word size of 8 bits for the
data blocks, with a special exception for the differential phase
product, which was hardcoded to use 16 bits. This PR enables the IOSP
and Level2 Record parser to use the actual word size as encoded in the
message.
@dopplershift dopplershift merged commit 2993fef into Unidata:maint-5.x Oct 9, 2020
@lesserwhirls lesserwhirls deleted the level2 branch October 9, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants