4.6.3 prep, upstream propegation #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…memory, as these were all introduced in hdf5 1.8.15.
re: #1337 tst_filterparser was creating but not using the baseline array. Instead, it did the same thing inline. Fixed code to use baseline array.
…nto v4.6.3-dev-branch.wif
edhartnett
reviewed
Feb 25, 2019
plugins/H5Zbzip2.c
Outdated
| @@ -7,6 +7,8 @@ | |||
| /* Older versions of the hdf library may define H5PL_type_t here */ | |||
| #include <H5PLextern.h> | |||
|
|
|||
| #include "config.h" | |||
There was a problem hiding this comment.
You need to put config.h before any other includes. Some of the settings in config.h may well impact other includes, so config.h has to come first.
….6.3-dev-branch.wif
…d by configure, in support of https://github.com/Unidata/netcdf-c/issues/gh1324
…ination-Council/netcdf-c into v4.6.3-dev-branch.wif
|
Not immediately available. I could create and attach one in a bit, but working on updating my internal windows package creating tool at the moment. |
|
If you have access to docker, you can run the following command in the meantime: I invoke it as follows: |
|
Thanks Ward for the compat report. Now I see a good bunch of ABI backward compatibility issues. Therefore I concur with your SO version bump from 14.2.1 to 15.0.0. "Case closed." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development branch to handle those changes in 4.6.3 that need to be merged back upstream.