Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First working version! #2

Merged
merged 18 commits into from
Mar 10, 2018
Merged

First working version! #2

merged 18 commits into from
Mar 10, 2018

Conversation

Glavin001
Copy link
Member

mar-09-2018 22-55-41

@Glavin001 Glavin001 self-assigned this Mar 10, 2018
@Glavin001 Glavin001 requested a review from stevenzeck March 10, 2018 02:56
Glavin001 and others added 12 commits March 9, 2018 22:57
@Glavin001
Add demo gif to README
76effe6
@Glavin001
Add Unibeautify config file
5050aad
🎨 Fix formatting of 5 files for commit 5050aad
d02b8f0
@Glavin001
Merge pull request #3 from Unibeautify/unibeautify/vacation/push
ae567c5 
🎨 Fix formatting of 5 files for commit 5050aad
@Glavin001
Add Prettier config to VSCode workspace, remove old code
9d0bf83
@Glavin001
Setup Mocha tests and Travis CI
67a31ed
🎨 Fix formatting of 1 file for commit 67a31ed
306b614
@Glavin001
Merge pull request #4 from Unibeautify/unibeautify/vacation/push
1b0bd48 
🎨 Fix formatting of 1 file for commit 67a31ed
@Glavin001
Update .unibeautifyrc.yml
3a1bff4
🎨 Fix formatting of 1 file for commit 3a1bff4
a8fd2b0
@Glavin001
Merge pull request #6 from Unibeautify/unibeautify/Glavin001-patch-1/…
7372e80 
…push

🎨 Fix formatting of 1 file for commit 3a1bff4
@Glavin001
Merge pull request #5 from Unibeautify/Glavin001-patch-1
304cb27 
Update .unibeautifyrc.yml
@mblode
Copy link

mblode commented Mar 10, 2018

How can I help with this project's development?

@stevenzeck
Copy link
Contributor

Why Mocha instead of Jest?

@Glavin001
Copy link
Member Author

@mblode : Awesome to hear! I am still setting up the foundation. I will try to create more Issues soon with label good first issue and/or help wanted which would be great places for you to start contributing 😃.

@Glavin001
Copy link
Member Author

@szeck87 : I plan on switching them over to Jest. I used https://github.com/Microsoft/vscode-generator-code/tree/20af6eee7d7b22f2236f6c2d1a7b7809a519392e/generators/app/templates/ext-command-ts to get started. Could not find a Jest example. Will be coming in a future PR, or maybe something another contributor could work on 😉. I created #8 for anyone to take.

@Glavin001 Glavin001 merged commit c6d0617 into master Mar 10, 2018
stevenzeck
stevenzeck reviewed Mar 10, 2018
View reviewed changes
Copy link
Contributor

@stevenzeck stevenzeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ava should be removed as a dev dependency

@Glavin001
Copy link
Member Author

I'm having major troubles publishing the extension. See #11 (comment) . Please help if you can!

@Glavin001 Glavin001 deleted the vacation branch April 27, 2018 04:49
Glavin001 pushed a commit that referenced this pull request Sep 23, 2018
@muuvmuuv
Merge pull request #2 from Unibeautify/master
2f83979 
Update to remote master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenzeck stevenzeck stevenzeck left review comments

Assignees

@Glavin001 Glavin001

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Glavin001 @mblode @stevenzeck