Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add margin to any positions #625

Merged
merged 21 commits into from
Jul 5, 2023
Merged

Add margin to any positions #625

merged 21 commits into from
Jul 5, 2023

Conversation

taiki1frsh
Copy link
Collaborator

close #440

  • Implement MsgAddMargin logic
  • Refactor the liquidation process by separating the condition checker and business operation

@Senna46 Senna46 mentioned this pull request Jun 25, 2023
Merged
@Senna46
Copy link
Contributor

Senna46 commented Jun 25, 2023

@kimurayu45z
Do I need to deposit or withdraw margin? Since there is currently no Close fee, it is a loss to do this and the best course of action is to Close in less than 8 hours.

It is also an option to activate only AddMargin, which allows anyone to add margins.

Senna46
Senna46 requested changes Jun 25, 2023
View reviewed changes
Copy link
Contributor

@Senna46 Senna46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taiki1frsh Reviewed. Plz fix them.

@Senna46
Copy link
Contributor

Senna46 commented Jun 30, 2023

@taiki1frsh OK
Also, please correct CI.

@taiki1frsh
Copy link
Collaborator Author

taiki1frsh commented Jul 1, 2023 •
edited
Loading

@taiki1frsh OK Also, please correct CI.

@Senna46
Now it's alright.

@taiki1frsh taiki1frsh merged commit b7cac5b into newDevelop Jul 5, 2023
@taiki1frsh taiki1frsh deleted the feature/add-margin-to-any-positions branch July 5, 2023 00:23
Senna46 added a commit that referenced this pull request Jul 27, 2023
@Senna46
fix: #625 bug
1f9af81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Senna46 Senna46 Senna46 approved these changes

@kimurayu45z kimurayu45z Awaiting requested review from kimurayu45z

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[derivatives] Adding margin feature
2 participants
@taiki1frsh @Senna46