change the way to create any obj #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| market := types.Market{ | ||
| BaseDenom: baseDenom, | ||
| QuoteDenom: quoteDenom, | ||
| } | ||
| msg := types.NewMsgOpenPosition(sender, margin, market, positionInstance) | ||
| msg := types.NewMsgOpenPosition(sender, margin, market, *piAny) | ||
| if err := msg.ValidateBasic(); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
The code appears to be making changes in a blockchain application, specifically in the open-position function of the perpetual-futures transaction.
As for the specific review points:
- The commented out code block suggests that the previous approach using positionInstBz has been replaced with piAny. This is likely done to improve efficiency since Any is Protobuf's way of handling arbitrary types.
- There are no apparent bug risks on the updated lines of code.
- One suggestion for improvement could be to comment why the previous code block was commented out, just for clarity purposes.
kimurayu45z
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #442