feat: disable mod #516
Merged
feat: disable mod #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -97,7 +98,7 @@ func (tApp TestApp) GetUpgradeKeeper() *upgradekeeper.Keeper { return tApp.Upgr | |||
| func (tApp TestApp) GetParamsKeeper() paramskeeper.Keeper { return tApp.ParamsKeeper } | |||
|
|
|||
| // func (tApp TestApp) GetVVKeeper() validatorvesting.Keeper { return tApp.vvKeeper } | |||
| func (tApp TestApp) GetPriceFeedKeeper() pricefeedkeeper.Keeper { return tApp.PricefeedKeeper } | |||
| // func (tApp TestApp) GetPriceFeedKeeper() pricefeedkeeper.Keeper { return tApp.PricefeedKeeper } | |||
|
|
|||
| // func (tApp TestApp) GetHarvestKeeper() harvest.Keeper { return tApp.harvestKeeper } | |||
| // func (tApp TestApp) GetCommitteeKeeper() committee.Keeper { return tApp.committeeKeeper } | |||
There was a problem hiding this comment.
This code patch removes the import of "github.com/UnUniFi/chain/x/pricefeed/keeper" and comments out a function that returns a PriceFeedKeeper. There seems to be no bug risk associated with these changes. However, it may be worth investigating why the PriceFeedKeeper was commented out - if it is no longer being used, then no improvement suggestions are necessary. If it is still being used, then it may be beneficial to update the code to reflect the changes made to the price feed module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable all ununifi mods (with the exception of wasm)