modify: fix formula bug #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimurayu45z
requested changes
Mar 9, 2023
| func NormalToMicroDenom(amount sdk.Dec) math.Int { | ||
| return amount.Mul(sdk.MustNewDecFromStr("1000000")).TruncateInt() | ||
| } | ||
|
|
||
| func (m PerpetualFuturesPosition) CalcReturningAmountAtClose(closedRate sdk.Dec) (returningAmount math.Int, lossToLP math.Int) { | ||
| func (m PerpetualFuturesPosition) CalcReturningAmountAtClose(baseUSDRate, quoteUSDRate sdk.Dec) (returningAmount math.Int, lossToLP math.Int) { |
There was a problem hiding this comment.
全体的に、xxxUSDRateではなくxxxMetricsRateのほうが良いと思います。
一応USDというのはハードコーディングされてるわけではなくてParamsでmetricsのtickerが"USD"だと指定されているだけなので。
There was a problem hiding this comment.
はい、それにしたいです
ただ、debugするときに
sdk.decで引き釣りまわすと、これは何のrateかわからなくなることが多々あります
MetricsRateTypeを作って
{
MetricsUnit: denom
rate sdk.Dec
}
を使いたいです
There was a problem hiding this comment.
↑を書き換えるタイミングで変数名を直すのはどうでしょうか？
POC開始したらすぐに直す予定です
| } | ||
|
|
||
| // func (m PerpetualFuturesPosition) RequiredMarginInMetrics(requiredMarginInQuote, quoteUSDRate sdk.Dec) sdk.Dec { | ||
| func (m PerpetualFuturesPosition) RequiredMarginInMetrics(baseUSDRate, quoteUSDRate sdk.Dec) sdk.Dec { |
There was a problem hiding this comment.
ここではmarginMetricsRateひとつだけを引数にうけとるようにして、
MarginMetricsRate(baseMetricsRate, quoteMetricsRate sdk.Dec) sdk.Dec
みたいな関数つくってそこでif分岐させるのはどうでしょうか。将来的にはbaseまたはquote以外のdenomもmarginにいれられるようにする拡張というのもありえなくはないので。
There was a problem hiding this comment.
こちらもPOC開始後対応でよいですか？
Issueは作っておきます
kimurayu45z
approved these changes
Mar 9, 2023
This was referenced Mar 9, 2023
modify: fix query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.