Feat/derivatives fix command close potision #388
Conversation
…nto feat/derivatives-fix-command-close-potision Conflicts: x/derivatives/keeper/perpetual_options.go x/derivatives/keeper/positions.go
scripts/setup/init.sh
Outdated
| @@ -78,13 +79,17 @@ jq '.app_state.derivatives.params.perpetual_futures.commission_rate = "0.001"' $ | |||
| jq '.app_state.derivatives.params.perpetual_futures.margin_maintenance_rate = "0.5"' $NODE_HOME/config/genesis.json > temp.json ; mv temp.json $NODE_HOME/config/genesis.json; | |||
| jq '.app_state.derivatives.params.perpetual_futures.imaginary_funding_rate_proportional_coefficient = "0.0005"' $NODE_HOME/config/genesis.json > temp.json ; mv temp.json $NODE_HOME/config/genesis.json; | |||
| jq '.app_state.derivatives.params.perpetual_futures.markets = [{"base_denom": "ubtc", "quote_denom": "uusd" }]' $NODE_HOME/config/genesis.json > temp.json ; mv temp.json $NODE_HOME/config/genesis.json; | |||
There was a problem hiding this comment.
please change "uusd" to "uusdc".
didn't check it, sorry.
scripts/commands/derivatives/msgs.sh
Outdated
| @@ -12,8 +12,11 @@ $BINARY tx derivatives burn-lpt 1 ubtc --from=$USER1 $conf | jq .raw_log | sed ' | |||
| $BINARY tx derivatives burn-lpt 1 ubtc --from=$USER1 $conf | jq .raw_log | sed 's/\\n/\n/g' | |||
|
|
|||
| # open-position perpetual-futures | |||
| $BINARY tx derivatives open-position perpetual-futures 100ubtc ubtc uusdc long --from=$USER1 $conf | jq .raw_log | sed 's/\\n/\n/g' | |||
| $BINARY tx derivatives open-position perpetual-futures 100uusdc ubtc uusdc short --from=$USER1 $conf | jq .raw_log | sed 's/\\n/\n/g' | |||
| $BINARY tx derivatives open-position perpetual-futures 100ubtc ubtc uusd long --from=$USER1 $conf | jq .raw_log | sed 's/\\n/\n/g' | |||
There was a problem hiding this comment.
plz change "uusd" to "uusdc" after the change of the markets values in genesis.json.
plz refer init.sh file comment
There was a problem hiding this comment.
uusdc does't work.
uusd is working
There was a problem hiding this comment.
with this modification (#388 (comment)), it should work.
There was a problem hiding this comment.
No, it does not work.
I have tried that.
There was a problem hiding this comment.
sorry, needed one more modification.
#388 (comment)
x/derivatives/keeper/positions.go
Outdated
| positionId := string(positionKey) | ||
| lastPosition, err := k.GetLastPosition(ctx) | ||
| if err != nil { | ||
| panic("failed to get last position") |
There was a problem hiding this comment.
maybe better to define Error case and return err, instead of executing panic?
There was a problem hiding this comment.
This case is usually not possible.
In such cases, Chain should be stopped.
There was a problem hiding this comment.
Sorry, I made a mistake.
I've fixed it
|
@taiki1frsh |
This reverts commit 328a18b.
scripts/setup/init.sh
Outdated
| jq '.app_state.derivatives.params.perpetual_futures.markets = [{"base_denom": "ubtc", "quote_denom": "uusdc" }]' $NODE_HOME/config/genesis.json > temp.json ; mv temp.json $NODE_HOME/config/genesis.json; | ||
| jq '.app_state.bank.denom_metadata = [ | ||
| {"base" : "ubtc" , "symbol": "ubtc"}, | ||
| {"base" : "uusd", "symbol": "uusdc"} |
There was a problem hiding this comment.
plz change "uusd" to "uusdc" here
No description provided.