add spec for x/derivatives #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki1frsh
changed the title
|
I wrote down the fundamental features and specifications in a text besides basic data structures. |
kimurayu45z
requested changes
Mar 22, 2023
x/derivatives/spec/01_concepts.md
Outdated
|
|
||
| ## Liquidity Provider Token | ||
| There's no dynamic change of the minting and redemption fee rate at this moment unlike GMX. It's the static rate which is defined in the protocol. But, it can be modified through the governace voting. |
There was a problem hiding this comment.
There was a problem hiding this comment.
I modified it.
Please check the above line.
x/derivatives/spec/01_concepts.md
Outdated
| The position can be covered by two types of asset as margin, which are the tokens of the trading pair. If you trade 'BTC/USDC' pair, you can deposit BTC or USDC as margin. The profit will be distributed in the same token as the margin if there's some. | ||
| The created position cannot be modified except for closing a whole in the current implementation. | ||
| And, the liquidation is triggered against each position. The margin of the position cannot be added afterward now. But, this will be supported in the near future. | ||
| The max leverate rate is defined in the params of the protocol for all trading pairs equially. This can be modified through the governance voting. |
taiki1frsh
changed the title
kimurayu45z
approved these changes
Mar 24, 2023
|
|
||
| ## Liquidity Provider Token | ||
| There's dynamic change of the minting and redemption fee rate at this moment. There's the static rate which is defined in the protocol. And, the actual fee rate also consider the difference of asset proportion between target and actual proportion. The static base fee rate can be modified through the governace voting. | ||
|
|
There was a problem hiding this comment.
Plz add something like
mintFeeRate is proportion to max(0, (actualAmountInPool[i] - targetAmount[i]) / targetAmount[i])
redeemFeeRate is proportion to max(0, -(actualAmountInPool[i] - targetAmount[i]) / targetAmount[i])
There was a problem hiding this comment.
Okay, thanks for the content.
Will put it.
By the way, I (and @mkXultra ) are planning to increment those more technical specs hereafter the general spec on text is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fill spec