enable data in geneis state to be exported #310
Conversation
| if err := ValidateClassAttributes(*classAttributes, gs.Params); err != nil { | ||
| return err | ||
| } | ||
| } |
There was a problem hiding this comment.
I think more validations will need to be added here for ClassNameIdLists and OwningClassIdLists.
As well as usage of usage of class ids on OwningClassIdLists that's not on ClassNameIdLists
There was a problem hiding this comment.
i know.
was thinking about whether i should add that kind of validation for those.
But, eventually i didn't do that since x/nftmarket doesn't have those type of validation, too, right?
do you even think i should add here now?
There was a problem hiding this comment.
Not a mandatory one but would be good to add for completeness.
There was a problem hiding this comment.
@mkXultra
what do you think?
should i do this for this PR or do i just put this as an issue and give someone else this task?
There was a problem hiding this comment.
@taiki1frsh
How long will it take?
There was a problem hiding this comment.
@mkXultra
without test, it doesn't take an hour.
with out, i guess around four or five hour.
issue #308
(mistook naming branch name)
what i did:
GetClassAttributesList,GetOwningClassIdLists,GetClassNameIdListsto extract all data for each typesno tests for the methods yet, but i think this can be merged first. (made the other issue for it already)