-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update cesm driver namelist defaults #800
Changes from 5 commits
31625ee
b6a25c4
ab8b5cc
42741c8
46dc9e0
d4c1a79
dd22880
a5aa6bd
8c3ffec
29364dc
9f3a4c9
76feedb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -91,7 +91,8 @@ def copy_to_rundir(grid_config, caseid, rundir, casedocs): | |
|
||
# copy file | ||
copy_clean_vic_config(grid_config[filekey], dst_file, | ||
header=header, rundir=rundir, **grid_config) | ||
header=header, rundir=rundir, | ||
caseid=caseid, **grid_config) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. indentation error here. |
||
|
||
# update the grid config | ||
grid_config[filekey] = dst_file | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,10 @@ | ||
# VIC Global Configuration File | ||
|
||
NODES 50 | ||
NODES 10 | ||
OUT_TIME_UNITS DAYS | ||
|
||
# Soil Temperature Options | ||
FULL_ENERGY TRUE | ||
FROZEN_SOIL TRUE | ||
QUICK_FLUX FALSE | ||
QUICK_SOLVE FALSE | ||
|
@@ -54,10 +55,19 @@ DOMAIN_TYPE FRAC frac | |
DOMAIN_TYPE YDIM nj | ||
DOMAIN_TYPE XDIM ni | ||
|
||
OUTFILE fluxes | ||
OUTFILE {caseid}.vic.ha | ||
AGGFREQ NDAYS 1 | ||
HISTFREQ END | ||
OUTVAR OUT_RUNOFF | ||
OUTVAR OUT_BASEFLOW | ||
OUTVAR OUT_SWE | ||
OUTVAR OUT_EVAP | ||
|
||
OUTFILE {caseid}.vic.hmm | ||
AGGFREQ NMONTHS 1 | ||
OUT_FORMAT NETCDF4_CLASSIC | ||
OUTVAR OUT_PREC | ||
HISTFREQ END | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. for both of these streams, I think you probably want the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What would There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Write one file with all history timesteps in it at the final timestep. This is probably not what you want. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated as suggested |
||
OUTVAR OUT_PREC | ||
OUTVAR OUT_RAINF | ||
OUTVAR OUT_SNOWF | ||
OUTVAR OUT_AIR_TEMP | ||
|
@@ -77,3 +87,11 @@ OUTVAR OUT_SWE | |
OUTVAR OUT_SOIL_MOIST | ||
OUTVAR OUT_ALBEDO | ||
OUTVAR OUT_SOIL_TEMP | ||
OUTVAR OUT_R_NET | ||
OUTVAR OUT_LATENT | ||
OUTVAR OUT_SENSIBLE | ||
OUTVAR OUT_RAD_TEMP | ||
OUTVAR OUT_SURF_TEMP | ||
OUTVAR OUT_SWNET | ||
OUTVAR OUT_LWNET | ||
OUTVAR OUT_GRND_FLUX | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggest adding frozen soil variables. You and @bartnijssen should probably iterate together on which variables you think would be potentially useful. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Having something that let's us identify active layer depth would be useful, but now sure whether that would be part of every run. Same for all these met variables. Can we split out the radiation variables (down and up rather than just net). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's what I was thinking too. From knowing how much outputting data for 10 thermal nodes increases the size of the output files, I think we should add that when we need it and not make it the default. I'll split out the radiation variables and remove some of the met ones There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remember this is just a monthly output file so the cost of writing out 3d vars is much less than it would otherwise be. My thought is that you should write out more variables, unless you have reason to think the data volumes will be out of control or that it is negatively impacting runtimes. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added soil node temperature to the monthly output files as well as eliminating some of the met vars and splitting out the radiation vars. @bartnijssen and @jhamman - what do you think of the updated ones? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
markdown automatically numbers this so the 1. was intentional here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @jhamman says. Leave the
1
for all the numbered entries. The1
just indicates that markdown should format this as an enumerated list and will take care of the actual numbering. It is much easier to leave that to markdown in case the list ever gets updated.