Fixed bugs related to volumetric heat capacity of water #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yixinmao - this branch needs to be updated and if we keep your changes to |
|
Update branch and then go ahead and merge. We should do a separate bug fix release for VIC 4.2 Go @yixinmao !! |
added 2 commits
August 10, 2016 09:33
…water_heat_capacity
`func_canapy_energy_bal.c`
| @@ -175,6 +175,9 @@ This is a major update from VIC 4. The VIC 5.0.0 release aims to have nearly ide | |||
|
|
|||
| Fixed a bug so that the binary format state file I/O works correctly. | |||
|
|
|||
| 5. Fix for a physical constant (water heat capacity) | |||
There was a problem hiding this comment.
Add the issue number here.
5. Fix for a physical constant (water heat capacity) ([GH#574](https://github.com/UW-Hydro/VIC/pull/574))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIC4.2- the hardcoded number4186.8here should be volumetric heat of water (which is 4186.8e3): https://github.com/UW-Hydro/VIC/blob/support/VIC.4.2.d/src/func_canopy_energy_bal.c#L262 . Other places inVIC4.2related to volumetric heat of water appear to be correct)