Fix OUTPUT_FORCE option. #307
Conversation
…ze_atmos() have information about the number of veg tiles in the grid cell to know how to read the forcing files (if they contain timeseries of LAI, vegcover, or albedo). Previously VIC wasn't reading the veg lib/param files when in OUTPUT_FORCE mode, which resulted in segmentation faults when trying to access veg_lib or veg_param data structures. Now VIC reads those files even in OUTPUT_FORCE mode.
|
Thanks @tbohn - Can you show a comparison of VIC 4.1.2 with |
|
You mean plot the outputs? On Mon, Nov 16, 2015 at 9:49 AM, Joe Hamman notifications@github.com
|
|
Yes - I think a test either plotting the outputs or numerical comparison is all we need to move on here. |
|
I just ran the two versions on a test grid cell and the results were On Mon, Nov 16, 2015 at 10:04 AM, Joe Hamman notifications@github.com
|
|
@bartnijssen - This is ready for your review. |
| } | ||
| if(NF>1) veg_hist[rec][v].LAI[NR] = sum / (float)NF; | ||
| sum += veg_hist[rec][v].LAI[i]; |
There was a problem hiding this comment.
Fix indentation on this line
|
1 indentation fix. @jhamman : After that, please go ahead and merge. |
|
@tbohn - this just needs one update and a rebase. Then 4.2.c is good to go. |
|
Can you be more specific about what I need to do (which github actions do I On Wed, Dec 9, 2015 at 9:12 AM, Joe Hamman notifications@github.com wrote:
|
|
@tbohn - This branch has merge conflicts that you need to resolve. You can do that by merging |
Conflicts: src/initialize_atmos.c
|
@jhamman OK, I believe I've resolved the merge conflicts. If you can look it over and let me know what you think, that would be great. |
|
Looks good. Thanks @tbohn. |
This addresses the requirement that initialize_atmos() have information about the number of veg tiles in the grid cell to know how to read the forcing files (if they contain timeseries of LAI, vegcover, or albedo). Previously VIC wasn't reading the veg lib/param files when in OUTPUT_FORCE mode, which resulted in segmentation faults when trying to access veg_lib or veg_param data structures. Now VIC reads those files even in OUTPUT_FORCE mode.
This addresses issue #305.