Add missing .adoc files to the tarball (alternative to #561) #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartwork
changed the title
Cropi
reviewed
Nov 16, 2022
| RUN mv -v usbguard-*.*.*/ usbguard-release/ | ||
| RUN mkdir usbguard-release/build/ | ||
| WORKDIR usbguard-release/build/ | ||
| RUN A2X=a2x ../configure --with-bundled-catch || ! cat config.log |
There was a problem hiding this comment.
What is the motivation behind A2X=a2x? I think that's the default as well or am I wrong?
There was a problem hiding this comment.
It was line
Line 657 in 673431e
and I was previously under the impression that
A2X=a2x would be needed to even have the docs be built. Good catch, dropped now, pushed.
hartwork
force-pushed
the
issue-561-adoc-files-missing-from-release-tarballs
branch
from
c7b7f7b to
1a9f9c4
Compare
Cropi
approved these changes
Nov 23, 2022
hartwork
deleted the
issue-561-adoc-files-missing-from-release-tarballs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to pull request #561 that also adds related regression tests to the CI.
CC @Cropi