Specify what happens when neither RuleFile nor RuleFolder is set

[Cropi]

Precisely specify what happens when neither RuleFile nor RuleFolder is set. Whilst this is an extraordinary use case, some might be confused in case they encounter the issue.

Reproduction of the issue is straightforward: remove RuleFile and RuleFolder from the config.

[hartwork]

Seems like a good idea 👍

Validated based on…

usbguard/src/Daemon/RuleSetFactory.cpp

Lines 66 to 76 in 927a41d

	if (!ns.getRulesPath().empty()) {
	ruleSet.emplace_back(new FileRuleSet(interface_ptr, ns.getRulesPath()));
	}
	if (!ns.getRulesDirPath().empty()) {
	for (auto path : getConfigsFromDir(ns.getRulesDirPath())) {
	auto frs = std::make_shared<FileRuleSet>(interface_ptr, path);
	auto rs = std::dynamic_pointer_cast<RuleSet>(frs);
	ruleSet.push_back(rs);
	}
	}

…and…

usbguard/src/Daemon/Daemon.cpp

Lines 198 to 225 in 927a41d

	/* RuleFile */
	if (_config.hasSettingValue("RuleFile")) {
	const std::string& rulefile_path = _config.getSettingValue("RuleFile");
	if (check_permissions) {
	checkFilePermissions(rulefile_path, (S_IRUSR | S_IWUSR));
	}
	_nss.setRulesPath(rulefile_path);
	}
	/* RuleDir */
	if (_config.hasSettingValue("RuleFolder")) {
	std::string ruledir_path = _config.getSettingValue("RuleFolder");
	/* Check proper ending in path and correct it if corrupted */
	if (ruledir_path.back() != '/') {
	ruledir_path.append("/");
	}
	ruledir_path = normalizePath(ruledir_path);
	if (check_permissions) {
	checkFolderPermissions(ruledir_path, (S_IRUSR | S_IWUSR));
	}
	_nss.setRulesDirPath(ruledir_path);
	}