Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with protobuf 30.0 #649

Open
christian-heusel opened this issue Mar 10, 2025 · 0 comments · May be fixed by #650
Open

Incompatible with protobuf 30.0 #649

christian-heusel opened this issue Mar 10, 2025 · 0 comments · May be fixed by #650

Comments

@christian-heusel
Copy link

Hello hello, Arch Linux packager here 👋🏻

We have recently started the protobuf 30.0 rebuild and the usbguard package is one of the holdups that came up along the way due to the following compiler error:

src/Library/IPCServerPrivate.cpp:314:87: error: invalid initialization of reference of type 'const std::string&' {aka 'const std::__cxx11::basic_string<char>&'} from expression of type 'google::protobuf::internal::GetTypeNameReturnType' {aka 'std::basic_string_view<char>'}
  314 |     hdr.id = QB_IPC_MSG_USER_START + IPC::messageTypeNameToNumber(message->GetTypeName());
      |                                                                   ~~~~~~~~~~~~~~~~~~~~^~
In file included from src/Library/IPCServerPrivate.hpp:24,
                 from src/Library/IPCServerPrivate.cpp:23:
src/Library/IPCPrivate.hpp:35:57: note: in passing argument 1 of 'uint32_t usbguard::IPC::messageTypeNameToNumber(const std::string&)'
   35 |     uint32_t messageTypeNameToNumber(const std::string& name);
      |                                      ~~~~~~~~~~~~~~~~~~~^~~~

I think this is due to a few string interface changes, see for example the changes from protobuf-c/protobuf-c#762 🤗

christian-heusel added a commit to christian-heusel/usbguard that referenced this issue Mar 11, 2025
Fixes USBGuard#649

Link: https://protobuf.dev/support/migration/
Signed-off-by: Christian Heusel <christian@heusel.eu>
@christian-heusel christian-heusel linked a pull request Mar 11, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant