enable branching ratio in BinNormalisationWithCalibration #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we were not using the radionuclide in the exam_info used for set_up, but an (uninitialised) class radionuclide class member, therefore always defaulting to 1 (afer writing a warning). However, this means that images will now have a different scale. Also remove the get/set_branching_ratio members, as they shouldn't really be part of the normalisation object. This therefore breaks backwards-compatibility!
|
I also just realised that if there is a calibration factor in the header this is not applied (SPECT) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not using the radionuclide in the exam_info used for set_up, but an (uninitialised) class radionuclide class member, therefore always defaulting to 1 (afer writing a warning).
However, this fix means that images will now have a different scale.
Also, remove the get/set_branching_ratio members, as they shouldn't really be part of the normalisation object.
This therefore breaks backwards-compatibility!
(There are currently still some typos here.)
This branch will undergo forced pushes, so be careful where you merge it!