Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axial symmetry fixes for BlocksOnCylindrical #1466

Conversation

markus-jehl
Copy link
Contributor

Changes in this pull request

Fix axial scanner downsampling and correct handling of gaps to make BlocksOnCylindrical axially symmetric.

Testing performed

See before and after in associated issue: #1465

Related issues

Fixes #1465
Relates to #1291

Checklist before requesting a review

  • [] I have performed a self-review of my code
  • [] I have added docstrings/doxygen in line with the guidance in the developer guide
  • [] I have implemented unit tests that cover any new or modified functionality (if applicable)
  • [] The code builds and runs on my machine
  • [] documentation/release_XXX.md has been updated with any functionality change (if applicable)

@KrisThielemans
Copy link
Collaborator

Could you add a note to release_6.2.htm, as well as the tiny comments on the scanner definition in the test function? (If only textual, commit with [ci skip] in the first line of the commit to prevent Appveyor going again).

@KrisThielemans KrisThielemans added this to the v6.2 milestone Jun 25, 2024
@markus-jehl
Copy link
Contributor Author

markus-jehl commented Jun 27, 2024

Projecting a symmetric cylinder with NeuroLF geometry gives only floating point level differences in symmetry (last plot is first axial half minus flipped second axial half of a viewgram):
image
image

@KrisThielemans KrisThielemans merged commit 7b1854b into UCL:master Jul 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugs in axial downsampling for BlocksOnCylindrical scanner geometry
2 participants