Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting a change that broke the blocks on cylindrical geometry. #1462

Conversation

markus-jehl
Copy link
Contributor

Changes in this pull request

Reverted a part of commit: 42bf1e9

Testing performed

Related issues

fixes #1390

Checklist before requesting a review

  • [] I have performed a self-review of my code
  • [] I have added docstrings/doxygen in line with the guidance in the developer guide
  • [] I have implemented unit tests that cover any new or modified functionality (if applicable)
  • [] The code builds and runs on my machine
  • [] documentation/release_XXX.md has been updated with any functionality change (if applicable)

@markus-jehl
Copy link
Contributor Author

@danieldeidda @KrisThielemans This is ready now from my side. The detector coordinate test could clearly be improved since we didn't notice the wrong geometry, but the python plotting tool shows that it is now correct.

@KrisThielemans
Copy link
Collaborator

Thanks @markus-jehl. Could you add a plot here for future reference? Please also modify the release_6.2.htm.

@danieldeidda please check.

@KrisThielemans KrisThielemans self-assigned this Jun 21, 2024
@KrisThielemans KrisThielemans added this to the v6.2 milestone Jun 21, 2024
@markus-jehl
Copy link
Contributor Author

image

@danieldeidda
Copy link
Collaborator

having a look now

@danieldeidda
Copy link
Collaborator

just for my understanding could it be possible to see the plot showing the wrong geometry

@KrisThielemans
Copy link
Collaborator

See #1390

Copy link
Collaborator

@danieldeidda danieldeidda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense to me. I am happy for this to be approved

@KrisThielemans
Copy link
Collaborator

Excellent. Squash merge ok?

@KrisThielemans KrisThielemans merged commit bdf04ac into UCL:master Jun 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blocks on cylindrical geometry still unexpected geometry
3 participants