-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverting a change that broke the blocks on cylindrical geometry. #1462
Reverting a change that broke the blocks on cylindrical geometry. #1462
Conversation
…i using the same logic than in plot_scanner_LORs.py
@danieldeidda @KrisThielemans This is ready now from my side. The detector coordinate test could clearly be improved since we didn't notice the wrong geometry, but the python plotting tool shows that it is now correct. |
Thanks @markus-jehl. Could you add a plot here for future reference? Please also modify the release_6.2.htm. @danieldeidda please check. |
having a look now |
just for my understanding could it be possible to see the plot showing the wrong geometry |
See #1390 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this makes sense to me. I am happy for this to be approved
Excellent. Squash merge ok? |
Changes in this pull request
Reverted a part of commit: 42bf1e9
Testing performed
Related issues
fixes #1390
Checklist before requesting a review
documentation/release_XXX.md
has been updated with any functionality change (if applicable)