Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOF loop missing for Hessian computation #1305

Closed
KrisThielemans opened this issue Jan 6, 2024 · 6 comments · Fixed by #1427
Closed

TOF loop missing for Hessian computation #1305

KrisThielemans opened this issue Jan 6, 2024 · 6 comments · Fixed by #1427

Comments

@KrisThielemans
Copy link
Collaborator

PoissonLogLikelihoodWithLinearModelForMeanAndProjData::actual_add_multiplication_with_approximate_sub_Hessian_without_penalty and other Hessian function don't loop over TOF data
@KrisThielemans KrisThielemans mentioned this issue Jan 6, 2024
Closed
@ghost
Copy link

ghost commented Jan 8, 2024

Is this as simple as updating the relevant lines to use the ViewgramIndices (#1273), e.g.
https://github.com/UCL/STIR/blob/75a9342157e59db6d43a968fa48f7d8c951853fb/src/recon_buildblock/PoissonLogLikelihoodWithLinearModelForMeanAndProjData.cxx#L949C49-L961

@KrisThielemans
Copy link
Collaborator Author

@gschramm, this is going to create trouble...

@KrisThielemans
Copy link
Collaborator Author

Actually, the list-mode Hessian should be fine.

@gschramm
Copy link
Contributor

@KrisThielemans and I am using non-TOF mMR data from the examples ;)

@gschramm
Copy link
Contributor

But good to keep that in mind and maybe warn people.

  • another reason to use torch.autograd.gradcheck to verify custom layers ...

KrisThielemans added a commit to KrisThielemans/STIR-1 that referenced this issue May 15, 2024
@KrisThielemans
add TOF loop in computation of Hessian for projdata
Loading
Loading status checks…
a32dac9 
Fixes UCL#1305
@KrisThielemans KrisThielemans mentioned this issue May 15, 2024
Merged
KrisThielemans added a commit to KrisThielemans/STIR-1 that referenced this issue May 15, 2024
@KrisThielemans
add TOF loop in computation of Hessian for projdata
Loading
Loading status checks…
7460c36 
Fixes UCL#1305
@KrisThielemans
Copy link
Collaborator Author

@gschramm I fixed this now.

NikEfth pushed a commit that referenced this issue May 16, 2024
@KrisThielemans @NikEfth
add TOF loop in computation of Hessian for projdata
b7003ad 
Fixes #1305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add TOF loop in computation of Hessian for projdata KrisThielemans/STIR-1
2 participants
@KrisThielemans @gschramm