Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chrisnasseh pull request (Lebanon's addition) #20

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

chrisnasseh
Copy link

@chrisnasseh chrisnasseh commented Oct 21, 2021

Copy link
Contributor

@dpshelio dpshelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution! Beautiful!!

I have only one request. Could you remove the two .DS_Store files that shouldn't be there?
(I imagine that you may have run a git add . or something similar, instead of adding the files individually. That's not a good practice, as you'll add files that were not intended to be added.)

@chrisnasseh
Copy link
Author

I noticed the two files being added automatically and after some research, it's because I am using a Mac. However, I don't know how to remove I can't find the actions I need to do. @dpshelio

@dpshelio
Copy link
Contributor

@chrisnasseh to remove the files you need to run git rm <filename>. Then to avoid other people adding these, you can create a .gitignore file on the top level with the pattern of the files you want to avoid being added by mistake.

@dpshelio dpshelio mentioned this pull request Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants