Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue #36 - Incorrect metadata directory and filename #37

Merged
merged 4 commits into from
May 31, 2023
Merged

Fix Issue #36 - Incorrect metadata directory and filename #37

merged 4 commits into from
May 31, 2023

Conversation

pavithraarizona
Copy link
Contributor

@pavithraarizona pavithraarizona commented May 31, 2023 •
edited
Loading

This pull request contains code that fixes the bug #36

  1. The variable 'version' holds the value 'v01'. Therefore, adding 'v' would result in 'vv01'. To correct this, the redundant 'v' is removed.
  2. In the preservation staging storage, the metadata filename does not have the phrase 'preservation_final_'. Hence 'preservation_final_' is removed.
  3. Updated if condition to check if the file or directory specified by metadata_path exist or not.
  4. Update the 'dryrun' parameter to 'False' to override the behavior specified by the @dryable(dry_return=('', '', Status.DRY_RUN)) decorator in the job.py file. Previously, the decorator indicated that the code should be executed in dry mode. However, by setting 'dryrun' to False, the code will now execute without the dry mode behavior.

@pavithraarizona
Fix Issue 36
6eac22c 
This commit will fix issue #36 

1. The variable 'version' holds the value 'v01'. Therefore, adding 'v' would result in 'vv01'. To correct this, the redundant 'v' is removed.
2. In the preservation staging storage, the metadata filename does not have the phrase 'preservation_final_'. Hence 'preservation_final_' is removed.
3. Update if condition to check if the file or directory specified by metadata_path exist or not.
@pavithraarizona
Update 'dryrun' parameter to False, overriding @dryable in job.py
39d8f94 
Update the 'dryrun' parameter to False. 

The purpose of this update is to override the behavior specified by the @dryable(dry_return=('', '', Status.DRY_RUN)) decorator in the job.py file. Previously, the decorator indicated that the code should be executed in dry mode. However, by setting 'dryrun' to False, the code will now execute without the dry mode behavior.
@pavithraarizona pavithraarizona changed the title Fix 36 Fix Issue #36 May 31, 2023
@pavithraarizona pavithraarizona linked an issue May 31, 2023 that may be closed by this pull request
Incorrect metadata directory and filename in bag.py file #36
Closed
1 task
@pavithraarizona pavithraarizona changed the title Fix Issue #36 Fix Issue #36 - Incorrect metadata directory and filename May 31, 2023
@pavithraarizona
Add parameter
8e0dc20 
Add parameter 'self' to the function
@pavithraarizona
Update log messages
57c3d66 
Update log messages
@zoidy zoidy mentioned this pull request May 31, 2023
Closed
1 task
@zoidy zoidy self-requested a review May 31, 2023 19:30
@zoidy zoidy merged commit 1347ab0 into main May 31, 2023
@zoidy zoidy deleted the Fix_36 branch May 31, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoidy zoidy zoidy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect metadata directory and filename in bag.py file
2 participants
@pavithraarizona @zoidy